Helm chart's default.yml is still based on Firefish #545

Open
opened 2024-04-29 16:11:48 +02:00 by mae · 12 comments
Member

The Helm chart still uses the old Firefish config as its base for the configuration secret it generates. It should be reworked to be based on Iceshrimp. While we're at it, we should probably refactor it in such a way where all config options can be configured.

I can start working on this soon if it's okay for the maintainers. ^^

The Helm chart still uses the old Firefish config as its base for the configuration secret it generates. It should be reworked to be based on Iceshrimp. While we're at it, we should probably refactor it in such a way where all config options can be configured. I can start working on this soon if it's okay for the maintainers. ^^
Owner

that would be very appreciated ^^

that would be very appreciated ^^
Owner

I'm happy to add you to the contributors team if you want

I'm happy to add you to the contributors team if you want
Author
Member

sure, why not? ^^
i’ll work in PRs and request approval for changes before merging them if that’s alright with you

sure, why not? ^^ i’ll work in PRs and request approval for changes before merging them if that’s alright with you
Owner

Aight ^^

Aight ^^
Author
Member

@zotan is ElasticSearch still a thing? I can only find it in the chart and commented out in the example docker-compose file.

@zotan is ElasticSearch still a thing? I can only find it in the chart and commented out in the example docker-compose file.
Owner

nope, and neither are sonic/meili. it’s all postgres now

nope, and neither are sonic/meili. it’s all postgres now
Contributor

Will iceshrimp.net will use a similar "API" for configuration/deployment @zotan. So for example will it also use a yaml file for configuration instad of e.g. using environment variables? For k8s deployments env variables would be preferable I think, at least to me the current approach of encoding the yaml file always felt a bit weird.

Also @mae if you want any help/review at some point I'd be happy to (but I am not a maintainer, I just also use & have contributed to this chart previously. In fact for the longest time I thought I was the only one ^^)

Will iceshrimp.net will use a similar "API" for configuration/deployment @zotan. So for example will it also use a yaml file for configuration instad of e.g. using environment variables? For k8s deployments env variables would be preferable I think, at least to me the current approach of encoding the yaml file always felt a bit weird. Also @mae if you want any help/review at some point I'd be happy to (but I am not a maintainer, I just also use & have contributed to this chart previously. In fact for the longest time I thought I was the only one ^^)
Owner

@corite It's gonna be an ini file in a location that's configurable via environment variables, though in theory you can override them via env vars, I think. Would have to check.

@corite It's gonna be an ini file in a location that's configurable via environment variables, though in theory you can override them via env vars, I think. Would have to check.
Owner

Yeah you can override it with env vars. For example, to change the option ImageProcessor in the section [Storage:MediaProcessing], you'd have to set the Storage__MediaProcessing__MediaProcessing environment variable

Yeah you can override it with env vars. For example, to change the option `ImageProcessor` in the section `[Storage:MediaProcessing]`, you'd have to set the `Storage__MediaProcessing__MediaProcessing` environment variable
Owner
Have a look at https://learn.microsoft.com/en-us/aspnet/core/fundamentals/configuration/?view=aspnetcore-8.0#non-prefixed-environment-variables for more details
Contributor

Ok, so if I understand you correctly the configuration format of ice shrimp.net (in file or env variables) will be incompatible with what we have today in ice shrimp.js (yaml), correct?

Ok, so if I understand you correctly the configuration format of ice shrimp.net (in file or env variables) will be incompatible with what we have today in ice shrimp.js (yaml), correct?
Owner

that is correct.

that is correct.
Sign in to join this conversation.
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: iceshrimp/iceshrimp#545
No description provided.