Admins should be able to move #488

Open
opened 2024-01-07 14:43:09 +01:00 by corite · 0 comments
Contributor

I stumbled onto this when migrating from firefish: I have a single user instance, therefore my normal account is also the admin account.

Unfortunately firefish (and also iceshrimp) prevents moving admin users. I don't think that is a good idea, especially for single user instances but also in general.

The check is in packages/backend/src/server/api/endpoints/i/move.ts, line 95. I think we should just remove it, or maybe display a popup and ask if the user really wants to do this.

Can one of the maintainers please signal whether they agree or not, and what action you want us to take. If it's just removing the line I can submit a PR, but displaying a popup is beyond me I'm afraid, so someone else would have to do that.

I stumbled onto this when migrating from firefish: I have a single user instance, therefore my normal account is also the admin account. Unfortunately firefish (and also iceshrimp) prevents moving admin users. I don't think that is a good idea, especially for single user instances but also in general. The check is in `packages/backend/src/server/api/endpoints/i/move.ts`, line 95. I think we should just remove it, or maybe display a popup and ask if the user really wants to do this. Can one of the maintainers please signal whether they agree or not, and what action you want us to take. If it's just removing the line I can submit a PR, but displaying a popup is beyond me I'm afraid, so someone else would have to do that.
AntoineD added the
enhancement
backend
labels 2024-01-07 17:17:06 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: iceshrimp/iceshrimp#488
No description provided.