Username parsing overhaul #444

Open
opened 2023-12-11 12:36:26 +01:00 by t.funken · 1 comment

Currently the interface is parsing everything beginning with a @ as a username.
This leads to various issues where other strings beginning with a @ also get treated as fediverse accounts even tho they aren't.

A example are matrix ID's where "@t.funken@as200950.com" is getting parsed as the local instance user "@t" while the "funken:as200950.com" part getting completely ignored. This not only applies to posts but also to profile information.

Screenshot from 2023-12-11 11-20-04.png

The parser also has issues to parse real fediverse accounts with dots in the username.

Screenshot 2023-12-05 at 23.12.49.png
(Screenshot from Ewan https://iceshrimp.social/notes/9mwjkxuevkucu7tt)

This leads to the issue that these accounts can't be mentioned.

As just everything is getting parsed, it also parses users from de-federated instances.
It doesn't pull any information's from those instances, but it still might be confusing for users to see a linked user account that just leads to a error page.

Screenshot from 2023-12-11 11-29-52.png

Currently the interface is parsing everything beginning with a @ as a username. This leads to various issues where other strings beginning with a @ also get treated as fediverse accounts even tho they aren't. A example are matrix ID's where "@t.funken@as200950.com" is getting parsed as the local instance user "@t" while the "funken:as200950.com" part getting completely ignored. This not only applies to posts but also to profile information. ![Screenshot from 2023-12-11 11-20-04.png](/attachments/92eb938f-9bd7-442a-be62-489aa69b3946) The parser also has issues to parse real fediverse accounts with dots in the username. ![Screenshot 2023-12-05 at 23.12.49.png](/attachments/05490158-f78b-43a2-a19f-c5007fed4930) (Screenshot from Ewan https://iceshrimp.social/notes/9mwjkxuevkucu7tt) This leads to the issue that these accounts can't be mentioned. As just everything is getting parsed, it also parses users from de-federated instances. It doesn't pull any information's from those instances, but it still might be confusing for users to see a linked user account that just leads to a error page. ![Screenshot from 2023-12-11 11-29-52.png](/attachments/5851fa0c-330e-443b-a3b7-f45fce8de1b9)
AntoineD added a new dependency 2023-12-11 13:22:09 +01:00
Member

Point 1 (Matrix) has already been mentioned in this issue: #73
Point 2 (Dot) has already been mentioned in this issue: #403

It doesn't seem to me that point 3 (de-federated instances) has already been mentioned. 😃

Point 1 (Matrix) has already been mentioned in this issue: #73 Point 2 (Dot) has already been mentioned in this issue: #403 It doesn't seem to me that point 3 (de-federated instances) has already been mentioned. 😃
AntoineD added the
bug
label 2023-12-11 13:25:01 +01:00
AntoineD added this to the MFM milestone 2023-12-11 13:25:04 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference: iceshrimp/iceshrimp#444
No description provided.