External videos have no preview thumbnail #402

Open
opened 2023-11-23 11:30:50 +01:00 by AntoineD · 2 comments
Member

I found a post that points out that external instance videos don't have a preview thumbnail.

I've checked this is the case.
Demo : https://next.iceshrimp.dev/notes/9melt1pkm5rycfwt

Apparently it's fixed in sharkey (I'll let you judge whether to cherry-pick or write our own fix).

image

I found a post that points out that external instance videos don't have a preview thumbnail. I've checked this is the case. Demo : https://next.iceshrimp.dev/notes/9melt1pkm5rycfwt Apparently it's fixed in sharkey (I'll let you judge whether to cherry-pick or write our own fix). ![image](/attachments/ffdcc112-aa96-4f9c-a4b3-fd6dd82b2b39)
188 KiB
AntoineD added the
bug
label 2023-11-23 11:30:50 +01:00
Contributor

Apparently it's fixed in sharkey (I'll let you judge whether to cherry-pick or write our own fix).

the only thing i can think of that's sharkey specific is that sharkey bundles in a statically compiled version of ffmpeg in it's dockerfiles to save (a tiny bit of) disk space (as distro packages depend on mesa and x libraries and a whole bunch of other unnecessary cruft). so either that somehow fixes this or it's something fixed upstream and carried down into sharkey by the virtue of that

> Apparently it's fixed in sharkey (I'll let you judge whether to cherry-pick or write our own fix). the only thing i can think of that's sharkey specific is that sharkey bundles in a statically compiled version of ffmpeg in it's dockerfiles to save (a tiny bit of) disk space (as distro packages depend on mesa and x libraries and a whole bunch of other unnecessary cruft). so either that somehow fixes this or it's something fixed upstream and carried down into sharkey by the virtue of that
zotan self-assigned this 2023-11-24 00:45:30 +01:00

Hi!

I just recently set up a new Iceshrimp instance (again) fo testing the new features, and, stumbled upon your post and, well, i just set the Video Thumbnail generator in Sharkey, for make it work in my instance, i been using: https://github.com/markkimsal/video-thumbnailer It just works!

So, the relevant code in *key for the thumbnail are:
https://github.com/search?q=repo%3Amisskey-dev%2Fmisskey%20videoThumbnailGenerato&type=code

So, hope it helps in nailing the issue with that

Greets!

Hi! I just recently set up a new Iceshrimp instance (again) fo testing the new features, and, stumbled upon your post and, well, i just set the Video Thumbnail generator in Sharkey, for make it work in my instance, i been using: https://github.com/markkimsal/video-thumbnailer It just works! So, the relevant code in *key for the thumbnail are: https://github.com/search?q=repo%3Amisskey-dev%2Fmisskey%20videoThumbnailGenerato&type=code So, hope it helps in nailing the issue with that Greets!
AntoineD added this to the (deleted) project 2023-11-27 00:52:32 +01:00
AntoineD modified the project from (deleted) to (deleted) 2023-11-29 19:14:26 +01:00
AntoineD added this to the OtherKey features milestone 2023-12-06 19:34:44 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: iceshrimp/iceshrimp#402
No description provided.