[Enhancement] Local Only Icon #225

Closed
opened 2023-09-15 19:08:07 +02:00 by AntoineD · 11 comments
Member

Messages published only locally have a fist icon
image

I don't find this icon very representative and think we could find something better.

A few proposals :
imageimageimageimageimageimage

Messages published only locally have a fist icon ![image](/attachments/092a34bf-067f-4126-a052-96f785008703) I don't find this icon very representative and think we could find something better. A few proposals : ![image](/attachments/77adabeb-7cae-49a2-9d57-1aa9639f1e57)![image](/attachments/aeb4d043-b8f4-4a20-9e36-2e05ea0cbb80)![image](/attachments/810a4a87-a90e-479e-a3b9-5d3cf77a156d)![image](/attachments/d8ec9948-75de-45e9-8130-3d4cdd6c4a4e)![image](/attachments/8e65ffb8-fa8f-42c1-b352-88e699d28e58)![image](/attachments/c97b2dc1-41e7-4216-9bcf-431910f0665e)
AntoineD changed title from [icon] Local Only to [Enhancement] Local Only Icon 2023-09-15 19:08:45 +02:00
Member

To keep it consistent with Local timeline, we could use the users icon instead.

To keep it consistent with Local timeline, we could use the `users` icon instead.
aylamz added the
enhancement
frontend
labels 2023-09-15 19:14:47 +02:00
Owner

I quite liked the misskey biohazard icon but there's no equivalent icon in phosphor icons.

I quite liked the misskey biohazard icon but there's no equivalent icon in phosphor icons.
zotan self-assigned this 2023-09-19 00:15:29 +02:00
Author
Member

@zotan The "radioactive" icon looks a bit like "biohazard".
image

@zotan The "radioactive" icon looks a bit like "biohazard". ![image](/attachments/8c8e9ca5-b40f-4f67-a371-c5182c48c139)
5.4 KiB
Author
Member

I've just had an idea.
Since this icon represents the instance, it might be interesting to make it (and Local Timeline) configurable in .config.
That way, if an phosphoricons represents the theme of an instance, the instance can make it its own.

I'm also thinking of the icons indicating that an account is admin or moderator, which could be configurable.

I've just had an idea. Since this icon represents the instance, it might be interesting to make it (and Local Timeline) configurable in .config. That way, if an phosphoricons represents the theme of an instance, the instance can make it its own. I'm also thinking of the icons indicating that an account is admin or moderator, which could be configurable.
Author
Member

I just saw that Firefish changed this icon to users :
https://git.joinfirefish.org/firefish/firefish/-/merge_requests/10597/diffs

I just saw that Firefish changed this icon to `users` : https://git.joinfirefish.org/firefish/firefish/-/merge_requests/10597/diffs
AntoineD self-assigned this 2023-10-17 21:45:56 +02:00
Author
Member

I was inspired by this commit to make the icons customizable. : 7094d933bf

First I wanted to make the admin/modo icons before switching to the local icon.
But for the moment I can't…

Please, can someone look at my commit and explain what I should have done to display the custom class name? 4dde188989

I was inspired by this commit to make the icons customizable. : https://iceshrimp.dev/iceshrimp/iceshrimp/commit/7094d933bf7015aaf760b7d5f28e993ee0ae7073 First I wanted to make the admin/modo icons before switching to the local icon. But for the moment I can't… Please, can someone look at my commit and explain what I should have done to display the custom class name? https://iceshrimp.dev/AntoineD/iceshrimp/commit/4dde188989919e3c908b1ffee664834fb3fa3514
Member

I was inspired by this commit to make the icons customizable

I think icons should not be configurable, that's just some extra complexity we do not need.

> I was inspired by this commit to make the icons customizable I think icons should not be configurable, that's just some extra complexity we do not need.
Author
Member

I've found several *key instances (including mine) that use a css custom to make this change, so I thought it would be interesting to make it official.

I've found several *key instances (including mine) that use a css custom to make this change, so I thought it would be interesting to make it official.
Author
Member

@zotan you said:

User choice is one of our core principles, we don't want to turn into suckless where you have to fork and compile it & manage a patchset yourself just to change a simple ui style.

Is my idea too extreme, or does it fall within the scope of the personalization proposal?

I have the impression that personalization is a discussion that should be officially abolished.

I understand the simplicity arguments put forward by @aylamz, but on the other hand, I think it's a shame to make css tweaks or local forks for cosmetic reasons…

@zotan you said: > User choice is one of our core principles, we don't want to turn into suckless where you have to fork and compile it & manage a patchset yourself just to change a simple ui style. Is my idea too extreme, or does it fall within the scope of the personalization proposal? I have the impression that personalization is a discussion that should be officially abolished. I understand the simplicity arguments put forward by @aylamz, but on the other hand, I think it's a shame to make css tweaks or local forks for cosmetic reasons…
Owner

We can make properly configurable icons a separate issue, until which proposals of icon changes are very much within the scope of the project.

We can make properly configurable icons a separate issue, until which proposals of icon changes are very much within the scope of the project.
Author
Member

Done.

PR : #371

New issue : #372

Done. PR : https://iceshrimp.dev/iceshrimp/iceshrimp/pulls/371 New issue : #372
zotan referenced this issue from a commit 2023-11-10 02:04:33 +01:00
zotan referenced this issue from a commit 2023-11-10 04:19:16 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: iceshrimp/iceshrimp#225
No description provided.