iceshrimp/iceshrimp
iceshrimp/iceshrimp
15
32
Fork 25
Code Issues 246 Pull requests 4 Actions Packages Projects 3 Releases 26 Wiki Activity

Mastodon API: MFM not rendered, mentions sometimes incorrect, hashtags, links, formatting, etc. missing #161

New issue
Open
opened 2023-08-29 19:31:41 +02:00 by VyrCossont · 1 comment
VyrCossont commented 2023-08-29 19:31:41 +02:00
Contributor
Copy link

tl;dr: MFM isn't rendered to HTML for Mastodon API clients because escapeMFM just dumps MFM as text. While there is special-purpose handling for mentions (addMentionsToStatus), it's implemented incorrectly.

Impact: Hashtags, links, formatting, etc. in posts don't show up for Mastodon API clients. Mentions can be incorrectly formatted and/or link to the wrong account.

Details: There's a lot to copy over, so please see my comments and screenshots on the equivalent Firefish bug.

tl;dr: MFM isn't rendered to HTML for Mastodon API clients because `escapeMFM` just dumps MFM as text. While there is special-purpose handling for mentions (`addMentionsToStatus`), it's implemented incorrectly. Impact: Hashtags, links, formatting, etc. in posts don't show up for Mastodon API clients. Mentions can be incorrectly formatted and/or link to the wrong account. Details: There's a lot to copy over, so please see my comments and screenshots on [the equivalent Firefish bug](https://git.joinfirefish.org/firefish/firefish/-/issues/10543#note_362).
👍 1
jeder added the
bug
 label 2023-08-29 20:23:47 +02:00
zotan self-assigned this 2023-08-30 16:44:01 +02:00
zotan referenced this issue from a commit 2023-11-10 04:19:14 +01:00
WIP #161
zotan referenced this issue from a commit 2023-11-10 04:19:14 +01:00
WIP #161
zotan closed this issue 2023-11-10 04:19:15 +01:00
AntoineD commented 2023-11-10 12:46:14 +01:00
Member
Copy link

@zotan I think this issue auto-closed without being resolved because of the name of a cherry-pick commit.
Can you confirm that this is the case?

@zotan I think this issue auto-closed without being resolved because of the name of a cherry-pick commit. Can you confirm that this is the case?
jeder reopened this issue 2023-11-10 12:53:28 +01:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
dev
security/fetch-content-type
disable-post-imports
feat/web-rewrite
feat/client-fixup
feat/masto-push
feat/frontend-tweaks
feat/virtual-scroller
packaging/nix-test
feature/pleroma-fe
v2023.12.7
v2023.12.6
v2023.12.5
v2023.12.4
v2023.12.3
v2023.12.2
v2023.12.1
v2023.12
v2023.12-pre4
v2023.12-pre3
v2023.12-pre2
v2023.11.4
v2023.12-pre1
v2023.11.3
v2023.11.2
v2023.11.1
v2023.11
v2023.11-pre5
v2023.11-pre4
v2023.11-pre3
v2023.11-pre2
v2023.11-pre1
v2023.10.11-rc1
v2023.10.08-rc1
v2023.10.04
v2023.09.13-rc1
Labels
Clear labels   
accessibility

   
documentation
  
backend

   
bug

Something is not working

  
discussion

When the other labels don't fit & for meta topics

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

   
has-dependencies

   
help wanted

Need some help

  
invalid

Something is wrong

  
meta

   
more info needed

More information is needed

  
needs-rebase

   
performance

Something could & should be faster

  
wontfix

This won't be fixed

No labels
accessibility
documentation
backend
bug
discussion
duplicate
enhancement
frontend
has-dependencies
help wanted
invalid
meta
more info needed
needs-rebase
performance
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
zotan
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: iceshrimp/iceshrimp#161
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?